Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prompt with replay file #1758

Merged
merged 14 commits into from
Jul 11, 2023
Merged

Prompt with replay file #1758

merged 14 commits into from
Jul 11, 2023

Conversation

w1ndblow
Copy link
Contributor

@w1ndblow w1ndblow commented Aug 4, 2022

if replayfile have not all answers relatively cookiecutter config file it'll execute prompt operation

@w1ndblow
Copy link
Contributor Author

hi, @audreyfeldroy, @browniebroke, @ericof, @hackebrot, @insspb, @pydanny, @simobasso, @ssbarnea could you take a look my PR, please

Copy link
Member

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@w1ndblow Thanks for your work on this.

Would you add tests that demonstrate that this feature is working as expected?

@@ -4,3 +4,4 @@ pytest-mock
freezegun
safety
pre-commit
defer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where is this used?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missclick

@ericof ericof added the enhancement This issue/PR relates to a feature request. label Jun 13, 2023
@w1ndblow
Copy link
Contributor Author

i added one test, i can add more if needed

@w1ndblow w1ndblow requested a review from kurtmckee June 21, 2023 08:46
@w1ndblow
Copy link
Contributor Author

w1ndblow commented Jul 7, 2023

hi, could any one merge it? i merged this with main 3 times already :)

@ericof ericof added this to the 3.0.0 milestone Jul 7, 2023
@ericof ericof self-requested a review July 7, 2023 20:34
@ericof ericof modified the milestones: 3.0.0, 2.2.3 Jul 11, 2023
@ericof ericof merged commit 25f2e58 into cookiecutter:main Jul 11, 2023
21 checks passed
@vemonet vemonet mentioned this pull request Jul 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants