Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup files if panics during hooks - bugfix #1760

Merged
merged 4 commits into from
Jun 12, 2023

Conversation

liortct
Copy link
Contributor

@liortct liortct commented Aug 6, 2022

Addresses #1754.

Fixed bug where files aren't cleaned up during panics, by adding an additional exception catch.

@liortct
Copy link
Contributor Author

liortct commented Jan 11, 2023

Hi!
We started working on a new community fork of the Cookiecutter project, named Cookieninja.
The fork is found at: https://github.com/cookieninja-generator/cookieninja

We have re-opened and merged your PR in the Cookieninja project at cookieninja-generator/cookieninja#30

We're trying to bring the life back to this amazing project.
We are committed to reviewing and merging each PR in up to 2 weeks from the day it's opened (if there are no issues with it).
We'd really like you to join the fork, star it and contribute to it!

Thank you :)

Copy link
Member

@kurtmckee kurtmckee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jensens @ericof @browniebroke @pydanny Please merge this PR.

It appears to resolve an existing bug. #1754 can be closed manually after this merges (it is not a linked issue and will not close automatically when this merges).

@browniebroke
Copy link
Member

Please don't @ me, while I'm a member of the organisation, I'm not a maintainer of the cookiecutter CLI project.

@kurtmckee
Copy link
Member

My apologies!! It won't happen anymore. You're correct, I was looking at members of the organization.

Please have a good weekend!

@jensens jensens added the bug This issue/PR relates to a bug. label Jun 12, 2023
@jensens jensens merged commit aef160a into cookiecutter:main Jun 12, 2023
18 checks passed
@liortct liortct mentioned this pull request Nov 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This issue/PR relates to a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants