Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Copy without render #184

Closed
wants to merge 10 commits into from
Closed

Copy without render #184

wants to merge 10 commits into from

Conversation

LucianU
Copy link

@LucianU LucianU commented Jun 9, 2014

This continues the work started in PR #132. Looking forward to your feedback.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.31%) when pulling 7951342 on LucianU:copy-without-render into 3b84343 on audreyr:master.

@LucianU
Copy link
Author

LucianU commented Jun 9, 2014

I'll add some tests for the prompting part, because I see that the coverage decreased there.

@osantana
Copy link

osantana commented Jun 9, 2014

👍

@coveralls
Copy link

Coverage Status

Coverage increased (+0.25%) when pulling 4e4fbc4 on LucianU:copy-without-render into 3b84343 on audreyr:master.

@roadsideseb
Copy link

That's exactly what I need. Can't wait to see this in an upcoming release 👍

@pydanny
Copy link
Member

pydanny commented Jul 9, 2014

@LucianU - I'm kind of thick, so I have a stupid question: Does this pull request allow you to use cookiecutter to grab a template without rendering it?

@LucianU
Copy link
Author

LucianU commented Jul 9, 2014

@pydanny, it allows someone to specify a list of paths to directories or files that shouldn't be rendered. Instead, they are simply copied. Is that what you're asking?

@pydanny
Copy link
Member

pydanny commented Jul 9, 2014

@LucianU Ah... I think I get it now. If I'm not mistaken, this allows us to bypass rendering of files/directories named things like: \{\{ repo_name \}\}, correct? Which would make it crazy useful, especially for creating Cookiecutter templates for generating... Cookiecutter templates.

If that's the case, I'll argue for getting this into 0.8.0. 😄

@LucianU
Copy link
Author

LucianU commented Jul 10, 2014

Yes, that's one use case. I use it for my ansible setup. Ansible uses Jinja, so I need cookiecutter to ignore the directory where I keep all my playbooks, inventory files and so on.

@michaeljoseph michaeljoseph added this to the 0.8.x: File generation milestone Jul 13, 2014
@coveralls
Copy link

Coverage Status

Coverage increased (+0.25%) when pulling 0a492c8 on LucianU:copy-without-render into 3b84343 on audreyr:master.

"_copy_without_render": [
"*.html",
"*not_rendered_dir",
"rendered_dir/not_rendered_file.ini",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The extra comma inside this list gives me a ValueError: No JSON object could be decoded.

@lanshark
Copy link

I would love to see this functionality in 0.8.0. It allows us to use cookiecutter to do ansible tasks.

@pydanny
Copy link
Member

pydanny commented Oct 31, 2014

@LucianU Would you mind if I cherry-picked your stuff into a new branch and finish this out? You'll still get credit and kudos. 😺

@LucianU
Copy link
Author

LucianU commented Oct 31, 2014

Please do.

@pydanny
Copy link
Member

pydanny commented Nov 4, 2014

I'm on it!

@osantana
Copy link

osantana commented Nov 7, 2014

Hi, @pydanny!

I'm at PythonBrasil and we could talk (and work) on this Pull Request together if you wish.

Thanks,
Osvaldo

@lanshark
Copy link

lanshark commented Mar 3, 2015

So, is this idea dead? REALLY need this for ansible scripts

@pydanny
Copy link
Member

pydanny commented Mar 3, 2015

@lanshark, This is is not dead at all. I want this to work! However, getting this to work on all platforms is a must for Cookiecutter pull requests. Unfortunately, this PR is not passing all tests on all platforms and fixing that takes free time that we just don't have. Even evaluating PRs takes time we don't have. The issue is that we have to focus on jobs and gigs that pay the bills. What time is left for open source is unfortunately not that much, and usually dedicated to emergencies or smaller tasks that we can resolve in minutes rather than hours.

We've considered adding a donation button in order to have paid time for Cookiecutter. Do you think that would be a good idea? Would you or your company be willing to donate for professional quality work on this particular issue? If so, then I'll add it today and we'll be able to get on the problem right now.

@lanshark
Copy link

lanshark commented Mar 3, 2015

Hmm,

Hi Danny!

Wow - didn't expect to get an answer that quick! I certainly understand
the problem. I'm a full-time contractor too! Donations are always a
good idea...but don't expect to get a lot of money that way, unfortunately.

I would be willing to work on the problem. Is there a branch that's
attempted to merge this? What tests are failing? I have the time to
dedicate, and it's that important to me. But I didn't want to step on
toes, since it looked like it was in progress.

Let me know how I can help!

-Scott

On 3/3/15 1:22 PM, Daniel Greenfeld wrote:

@ianshark, This is is not dead at all. I want this to work! However,
getting this to work on all platforms is a must for Cookiecutter pull
requests. Unfortunately, this PR is not passing all tests on all
platforms and fixing that takes free time that we just don't have.
Even evaluating PRs takes time we don't have. The issue is that we
have to focus on jobs and gigs that pay the bills. What time is left
for open source is unfortunately not that much, and usually dedicated
to emergencies or smaller tasks that we can resolve in minutes rather
than hours.

We've considered adding a donation button in order to have paid time
for Cookiecutter. Do you think that would be a good idea? Would you or
your company be willing to donate for professional quality work on
this particular issue? If so, then I'll add it today and we'll be able
to get on the problem right now.


Reply to this email directly or view it on GitHub
#184 (comment).

@pydanny
Copy link
Member

pydanny commented Mar 4, 2015

@lanshark - it's pretty frustrating because myself, @audreyr, and @michaeljoseph would love to put more time into this project, especially in regards to the review of pull requests. We're trying to figure out a way to fund development, since this is a very favorite project of ours.

In any case, this PR is failing on Windows tests (what @appveyor tests). That is what needs to be fixed AFAIK.

@pydanny
Copy link
Member

pydanny commented Mar 21, 2015

@hackebrot Everyone would love to see this work. The challenge, of course, is windows.

@hackebrot
Copy link
Member

@pydanny Yeah I understand and I agree 100% that we should try to get this in. I thought about closing #132 and focussing on #184 instead. ☺️

hackebrot added a commit to hackebrot/cookiecutter that referenced this pull request Mar 22, 2015
@hackebrot
Copy link
Member

🔔 Copy without render is now available on master! 😃

See http://cookiecutter.readthedocs.org/en/latest/advanced_usage.html#copy-without-render

@roadsideseb
Copy link

🏆

@pydanny
Copy link
Member

pydanny commented Mar 24, 2015

Closing this with many thanks to @LucianU!

@pydanny pydanny closed this Mar 24, 2015
@LucianU
Copy link
Author

LucianU commented Mar 25, 2015

Happy to have contributed and happy to see this merged in.

@clarkevans
Copy link

Danny, I realize doing releases is always work, but it'd be great if this were released to pypi.
Do you know when you'll have a point release? We use this feature for our cookie-cutters.
Thank you so much.

@pydanny
Copy link
Member

pydanny commented May 27, 2015

Hopefully this week. We have a period of slowdown between now and the arrival of what is hopefully the last proof of our book. Which means maybe tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement This issue/PR relates to a feature request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants