Allow setting parameters with no defaults

[johtso]

Fixes #587

[codecov-io]

Current coverage is 99.22%

Merging #588 into master will increase coverage by +0.01% as of 48b1464

@@            master    #588   diff @@
======================================
  Files           12      12       
  Stmts          511     513     +2
  Branches         0       0       
  Methods          0       0       
======================================
+ Hit            507     509     +2
  Partial          0       0       
  Missed           4       4       

Review entire Coverage Diff as of 48b1464

---

Uncovered Suggestions

1. +0.39% via ...ookiecutter/utils.py#27...28
2. +0.39% via ...okiecutter/config.py#19...20

Powered by Codecov. Updated on successful CI builds.

[pydanny]

@johtso, thank you for your pull request. 🍪 😎

Could you add a test for the condition? While this is technically covered by tests (https://codecov.io/github/audreyr/cookiecutter/cookiecutter/prompt.py?ref=bc3cb0ed034bde485d963ee9b50217cbd29ee069), that you added code that's a false positive.

[johtso]

@pydanny will do!

[hackebrot]

Hi @johtso! 👋

Could you please explain why you would have a variable with a default that is null in your template? An empty string should work perfectly fine if you do not want to specify a particular string value.

[hackebrot]

This counteracts the extra test parameter! 😟

[johtso]

Right, because the assertion doesn't apply anymore (there's still the assertion above checking the return value).

I could assert that it's not called I suppose..

This test does feel like it's basically replicating the same logic as the function it's testing.. but that's probably hard to avoid with such small functions.

[johtso]

@hackebrot the idea was that sometimes there is no sensible default for a value and you want to require that the user supplies one.

Even if that's not a particularly useful use-case, it's definitely less surprising than converting null into 'None'.

[hackebrot]

Hey @johtso can you please rebase this guy? We sorted out the issues with AppVeyor and I'd like to see the test results for windows. Thank you 🙇

[johtso]

@hackebrot done 😸

[hackebrot]

This sentence seems wrong 😁

[johtso]

Any suggestions welcome! Looks like I kept a typo too..

[pydanny]

Grats on your first pull request here @johtso. Welcome aboard! 🚢 🚋

[johtso]

Cheers @pydanny