Make the build reproducible by avoiding nondeterministic kwargs #800
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst working on the Reproducible Builds effort [0], I noticed that cookiecutter could not be built reproducibly. As USER_CONFIG_PATH is pased on expanding ~ this varies between different systems, meaning that building the documentation on a different machine (or with a different $HOME) ends up with a different result: - [..] config_file=u'/nonexistent/first-build/.cookiecutterrc' [..] + [..] config_file=u'/nonexistent/second-build/.cookiecutterrc' [..] I would normally just change this to ``config_file=None`` and set it at runtime, but we need to be clever with NOT_PROVIDED to tell the difference between the case where we *actually* pass ``None`.. [0] https://reproducible-builds.org/ Signed-off-by: Chris Lamb <chris@chris-lamb.co.uk>
Current coverage is 100% (diff: 100%)@@ master #800 diff @@
====================================
Files 15 15
Lines 601 604 +3
Methods 0 0
Messages 0 0
Branches 0 0
====================================
+ Hits 601 604 +3
Misses 0 0
Partials 0 0
|
|
How's the |
|
On my system, it appears as: (I may be using a newer Sphinx that you that strips memory addresses.) |
|
Ping on this? :) |
|
Another friendly ping on this? :) |
|
Closing in favor of #861 😄 |
hackebrot
added a commit
that referenced
this pull request
Dec 8, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst working on the Reproducible Builds effort [0], I noticed
that cookiecutter could not be built reproducibly.
As USER_CONFIG_PATH is pased on expanding ~ this varies between different
systems, meaning that building the documentation on a different machine (or
with a different $HOME) ends up with a different result:
I would normally just change this to
config_file=Noneand set it atruntime, but we need to be clever with NOT_PROVIDED to tell the difference
between the case where we actually pass ``None`..
[0] https://reproducible-builds.org/
Signed-off-by: Chris Lamb chris@chris-lamb.co.uk