Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reproducible build with default config #861

Conversation

@hackebrot
Copy link
Member

hackebrot commented Dec 1, 2016

This is an alternative implementation for #800 to make kwargs deterministic.

I personally prefer a default_config=False flag over config_file=object() 馃檴

Please let me know your thoughts, @lamby. I should also mention that you will get credit for your contribution to cookiecutter regardless of whether we decide to use this PR instead of #800!

@hackebrot hackebrot mentioned this pull request Dec 1, 2016
10 of 10 tasks complete
@lamby

This comment has been minimized.

Copy link

lamby commented Dec 1, 2016

An elaboration (or better: a comment) on how you differentiating between being passed None and not being passed anything would seem to be a good idea.

@codecov-io

This comment has been minimized.

Copy link

codecov-io commented Dec 1, 2016

Current coverage is 100% (diff: 100%)

Merging #861 into master will not change coverage

@@           master   #861   diff @@
====================================
  Files          16     16          
  Lines         661    659     -2   
  Methods         0      0          
  Messages        0      0          
  Branches        0      0          
====================================
- Hits          661    659     -2   
  Misses          0      0          
  Partials        0      0          

Powered by Codecov. Last update 03dc984...7b66edf

@hackebrot

This comment has been minimized.

Copy link
Member Author

hackebrot commented Dec 1, 2016

@lamby I've updated the docstring of config.get_user_config()

@lamby

This comment has been minimized.

Copy link

lamby commented Dec 1, 2016

In terms of which to merge, I'm easy. :)

@hackebrot hackebrot merged commit 6f4edb2 into cookiecutter:master Dec 8, 2016
4 checks passed
4 checks passed
codecov/patch 100% of diff hit (target 100%)
Details
codecov/project 100% (+0.00%) compared to 03dc984
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@hackebrot hackebrot deleted the hackebrot:reproducible-build-with-default-config branch Dec 8, 2016
hackebrot added a commit that referenced this pull request Dec 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can鈥檛 perform that action at this time.