Reproducible build with default config #861
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hackebrot
added
enhancement
|
An elaboration (or better: a comment) on how you differentiating between being passed |
Current coverage is 100% (diff: 100%)@@ master #861 diff @@
====================================
Files 16 16
Lines 661 659 -2
Methods 0 0
Messages 0 0
Branches 0 0
====================================
- Hits 661 659 -2
Misses 0 0
Partials 0 0
|
|
@lamby I've updated the docstring of |
|
In terms of which to merge, I'm easy. :) |
michaeljoseph
approved these changes
Dec 7, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative implementation for #800 to make kwargs deterministic.
I personally prefer a
default_config=Falseflag overconfig_file=object()馃檴Please let me know your thoughts, @lamby. I should also mention that you will get credit for your contribution to cookiecutter regardless of whether we decide to use this PR instead of #800!