Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting temporary files fails silently (closes #748) #755

Merged
merged 1 commit into from
Aug 3, 2021

Conversation

e2jk
Copy link
Contributor

@e2jk e2jk commented Aug 3, 2021

Associated Template/Command/Core

Fixes an issue when running the create command for a new project (apparently only on Windows 10 [Enterprise]).
See linked issue #748 for more details.

PR Checklist

  • This comment contains a description of changes (with reason)
  • Contained in the linked issue
  • Referenced issue is linked
    • Yes, see above.
  • If you've fixed a bug or added code that should be tested, add tests!
  • Not sure how to reproduce this bug (plaftorm related)
  • Documentation in docs is updated
  • This change doesn't require user-facing documentation

Description of changes

See linked issue #748, short version: if deleting the temporary folder fails with a PermissionError, just ignore that and continue the process. These temporary files will be deleted upon the next reboot of the machine anyway.

Technical details

Seems to only have been happening on Windows 10 (Enterprise), but handling this exception for all platforms makes sense: even if this happened on Linux or MacOS, the user would likely just want to continue on with the creation of his project, not have to care why deleting temporary files failed.

Additional context

None

@Zethson
Copy link
Member

Zethson commented Aug 3, 2021

Agree with your reasoning. Thanks!

@Zethson Zethson merged commit 0ab450f into cookiejar:master Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants