Change exception handler to be pluggable

lib/barbeque/configuration.rb

@@ -5,7 +5,7 @@
 module Barbeque
   module Configuration
     DEFAULT_CONFIG = {
-      'exception_handler' => 'rails_logger',
+      'exception_handler' => 'RailsLogger',
       'runner'            => 'Docker',
     }
 

lib/barbeque/exception_handler.rb

@@ -2,24 +2,21 @@
 
 module Barbeque
   module ExceptionHandler
-    class << self
-      def handle_exception(e)
-        case Barbeque.config.exception_handler
-        when 'rails_logger'
-          rails_logger(e)
-        when 'raven'
-          Raven.capture_exception(e)
-        else
-          Rails.logger.fatal("Unexpected exception handler: #{Barbeque.config.exception_handler}")
-          rails_logger(e)
-        end
-      end
-
-      private
+    def self.handle_exception(e)
+      handler = const_get(Barbeque.config.exception_handler, false)
+      handler.handle_exception(e)
+    end
 
-      def rails_logger(e)
+    module RailsLogger
+      def self.handle_exception(e)
         Rails.logger.error("#{e.inspect}\n#{e.backtrace.join("\n")}")
       end
     end
+
+    module Raven
+      def self.handle_exception(e)
+        ::Raven.capture_exception(e)
+      end
+    end
   end
 end

spec/barbeque/exception_handler_spec.rb

@@ -0,0 +1,22 @@
+require 'rails_helper'
+require 'barbeque/exception_handler'
+
+describe Barbeque::ExceptionHandler do
+  describe '.handle_exception' do
+    let(:exception) do
+      StandardError.new('something went wrong').tap do |e|
+        e.set_backtrace(['barbeque.rb:1'])
+      end
+    end
+    let(:handler) { 'RailsLogger' }
+
+    before do
+      allow(Barbeque).to receive_message_chain(:config, :exception_handler).and_return(handler)
+    end
+
+    it 'handles exception with configured handler' do
+      expect(Barbeque::ExceptionHandler::RailsLogger).to receive(:handle_exception).with(exception)
+      Barbeque::ExceptionHandler.handle_exception(exception)
+    end
+  end
+end

spec/dummy/config/barbeque.yml

@@ -1,5 +1,5 @@
 default: &default
-  exception_handler: rails_logger
+  exception_handler: RailsLogger
   runner: Docker
 
 development: