Make delay_seconds optional in MessageEnqueueingService

cookpad · Aug 23, 2018 · e9f15ff · e9f15ff
1 parent f135c2f
commit e9f15ff
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 4 deletions.
diff --git a/app/services/barbeque/message_enqueuing_service.rb b/app/services/barbeque/message_enqueuing_service.rb
@@ -16,7 +16,7 @@ def self.sqs_client
   # @param [Object] message
   # @param [String] queue
   # @param [Integer, nil] delay_seconds
-  def initialize(application:, job:, message:, queue: nil, delay_seconds:)
+  def initialize(application:, job:, message:, queue: nil, delay_seconds: nil)
     @application = application
     @job         = job
     @queue       = queue || DEFAULT_QUEUE

diff --git a/spec/services/message_enqueuing_service_spec.rb b/spec/services/message_enqueuing_service_spec.rb
@@ -31,7 +31,6 @@
         queue:   job_queue.name,
         message: message,
         application: application,
-        delay_seconds: nil,
       ).run
       expect(result).to eq(message_id)
     end
@@ -47,7 +46,6 @@
             queue:   queue_name,
             message: message,
             application: application,
-            delay_seconds: nil,
           ).run
         }.to raise_error(ActiveRecord::RecordNotFound)
       end
@@ -72,7 +70,6 @@
           queue: job_queue.name,
           message: message,
           application: application,
-          delay_seconds: nil,
         ).run
         expect(result).to eq(message_id)
       end