Add error handling around SNS API calls #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eagletmt
reviewed
Apr 27, 2017
| @sns_topic_arns = fetch_sns_topic_arns | ||
| render :new | ||
| else | ||
| @sns_subscription.save |
There was a problem hiding this comment.
Use save! if you don't check the return value
| @@ -50,6 +61,8 @@ def destroy | |||
|
|
|||
| def fetch_sns_topic_arns | |||
| sns_client.list_topics.topics.map(&:topic_arn) | |||
| rescue Aws::Errors::MissingCredentialsError, Aws::SNS::Errors::AuthorizationError | |||
There was a problem hiding this comment.
I think these exceptions should be reported as 5xx error because sns:ListTopics permission is required in Barbeque
There was a problem hiding this comment.
I think so, too. fixed.
eagletmt
approved these changes
Apr 27, 2017
k0kubun
approved these changes
Apr 27, 2017
done. I'll release v0.4.1. Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I add error handling around SNS API calls.
In our environment we want to restrict available topics to subscribe by IAM roles. So if a user is setting a restricted topic, Barbeque returns 500 error for now.
This patch avoids 500 error and shows error messages when accessing unauthorized topic or not found.
@cookpad/dev-infra @k0kubun How do you think?