Set error status when unhandled exception is raised from runner #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when unhandled exception is raised from custom runner, the execution status remains "pending" and there's no way to retry it after the exception is fixed.
eisuke
approved these changes
Apr 28, 2017
k0kubun
reviewed
Apr 28, 2017
| stdout, stderr, status = run_command | ||
| begin | ||
| stdout, stderr, status = run_command | ||
| rescue Exception => e |
There was a problem hiding this comment.
I guess you chose not StandardError but Exception to cover SignalException, for the case a job gets stuck and signal is sent to kill it. (I just wanted to know the background.)
There was a problem hiding this comment.
Any kind of exception could be raised from the runner in theory and the job_execution status should not remain pending in any case.
k0kubun
approved these changes
Apr 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, when unhandled exception is raised from custom runner, the
execution status remains "pending" and there's no way to retry it after
the exception is fixed.
@cookpad/dev-infra @k0kubun please review