Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy SNS subscriptions before destroying job definition #24

Merged
merged 2 commits into from
May 22, 2017
Merged

Destroy SNS subscriptions before destroying job definition #24

merged 2 commits into from
May 22, 2017
+168 −112

Conversation

eagletmt
Copy link
Member

@makimoto @cookpad/dev-infra please review

@eagletmt eagletmt requested a review from makimoto May 22, 2017 05:31
makimoto
makimoto approved these changes May 22, 2017
View reviewed changes
Copy link
Contributor

@makimoto makimoto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@eagletmt eagletmt merged commit 46ddf9e into cookpad:master May 22, 2017
@eagletmt eagletmt deleted the delete-subscription branch May 22, 2017 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makimoto makimoto makimoto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eagletmt @makimoto