Fix wrong aggregation query in /monitors #63
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previous query contained columns which isn't group-by target nor aggregators. Although MySQL accepts such query, it seems to do harm to performance.
taiki45
approved these changes
Apr 11, 2018
taiki45
reviewed
Apr 11, 2018
| } | ||
| jobs[job_id] = job | ||
| jobs[job[:job_id]] = job |
There was a problem hiding this comment.
nit: I prefer introducing job_id local var to avoid nesting the [] access.
riseshia
approved these changes
Apr 11, 2018
hokaccha
approved these changes
Apr 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous query contained columns which isn't group-by target nor
aggregators. Although MySQL accepts such query, it seems to do harm to
performance.
@cookpad/dev-infra please review