Fix Barbeque::SnsSubscriptionsController#fetch_sns_topic_arns #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itkq
force-pushed
the
fix-fetch-sns-topic-arns
branch
from
efac99d
to
141faf3
Compare
riseshia
reviewed
Jul 3, 2018
| next_token = nil | ||
|
|
||
| loop do | ||
| list_topics = Barbeque::SNSSubscriptionService.sns_client.list_topics(next_token: next_token) |
There was a problem hiding this comment.
FYI https://github.com/aws/aws-sdk-ruby#paging-responses
To make it easy to get the next page of results, every AWS response object is enumerable:
itkq
force-pushed
the
fix-fetch-sns-topic-arns
branch
from
141faf3
to
780fcc0
Compare
|
cc @cookpad/dev-infra |
riseshia
reviewed
Jul 3, 2018
| end | ||
|
|
||
| def each_sns_topic_arns | ||
| unless block_given? |
There was a problem hiding this comment.
is there any reason you want to support passing block?
itkq
force-pushed
the
fix-fetch-sns-topic-arns
branch
from
780fcc0
to
83d93e1
Compare
ganmacs
reviewed
Jul 3, 2018
| @@ -44,6 +44,6 @@ def destroy | |||
| private | |||
|
|
|||
| def fetch_sns_topic_arns | |||
| Barbeque::SNSSubscriptionService.sns_client.list_topics.topics.map(&:topic_arn) | |||
| Barbeque::SNSSubscriptionService.sns_client.list_topics.flat_map{ |resp| resp.topics.map(&:topic_arn) } | |||
There was a problem hiding this comment.
This is enough, isn't it.
Barbeque::SNSSubscriptionService.sns_client.list_topics.flat_map(&:topics).map(&:topic_arn)
itkq
force-pushed
the
fix-fetch-sns-topic-arns
branch
from
83d93e1
to
b28f812
Compare
|
LGTM |
eagletmt
approved these changes
Jul 4, 2018
ganmacs
approved these changes
Jul 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aws::SNS::Client#list_topics returns up to 100 topics. This
change allows to fetch all topics when there are more than 100
topics.