better error handling: raise Chanko::ActiveIf::NoConditionFound for undefined conditions #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when a specified condition is not defined, instead of raising method missing error for nil
| should be_nil | ||
| rescue Chanko::ActiveIf::NoConditionFound => e | ||
| e.message.should =~ /this_is_not_a_condition/ | ||
| end |
There was a problem hiding this comment.
Why don't you use expect { ... }.to raise_error helper?
https://www.relishapp.com/rspec/rspec-expectations/v/3-0/docs/built-in-matchers/raise-error-matcher
expect { subject }.to raise_error(..., /.../)
|
I just nitpicked, but otherwise looks Great 👍 |
r7kamura
added a commit
that referenced
this pull request
Dec 6, 2013
better error handling: raise Chanko::ActiveIf::NoConditionFound for undefined conditions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
active_ifrunner raises NoMethodError for nil:NilClass if a specified condition is not defined, but it is not clear.This patches fixes it to raise Chanko::ActiveIf::NoConditionFound to clarify what happens.
@hotchpotch @r7kamura Can you review this p-r please?