Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use stack control instead of counting #47

Merged
merged 1 commit into from
May 12, 2015
Merged

use stack control instead of counting #47

merged 1 commit into from
May 12, 2015

Conversation

eudoxa
Copy link
Contributor

@eudoxa eudoxa commented May 12, 2015

Counting depth does not work when 'invoke' is called by default block.
I use unstack block instead of counting depth. it work.

@hotchpotch
Copy link
Contributor

LGTM 👀

@@ -95,14 +95,15 @@ def __has_default_block?
def __invoke_default_block
current_default_block = __default_block
begin
__increment_run_default_depth
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

__increment_run_default_depth を呼ばなくなってるので #45 で追加した __current_run_default_depth は常に 0 のままだと思うんですが大丈夫ですか?
大丈夫なら、#45 で入った __current_run_default_depth 等のメソッドを消してほしいです。

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

あ、そうですね。消します。

eudoxa added a commit that referenced this pull request May 12, 2015
@eudoxa eudoxa merged commit 96ca782 into cookpad:master May 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants