Remove the dependency to Gson #26
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
looks good 👀 |
|
I prefer it, even if it breaks backward compatibility. @rejasupotaro ping? |
Conflicts: demo/src/main/java/com/example/puree/logs/PureeConfigurator.java puree/build.gradle puree/src/main/java/com/cookpad/puree/Puree.java puree/src/main/java/com/cookpad/puree/PureeConfiguration.java
|
I'm sorry I have rewrite Puree to use Gson heavily in #32. In fact, Gson's |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Thanks for that nice library.
But Gson is not the only one library to handle JSON, and as is well known, using several libraries for the same purpose is not fitting to build apks, so implicitly depending to such a library is not good.
I remove the dependency to Gson by default because of above, though the compatibility is lost. I hope the implicit dependency is removed anyway, so this request is simply to acknowledge that.
Thanks.