Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Bitbucket compare links. #65

Merged
merged 2 commits into from
Oct 8, 2018
Merged

Fix Bitbucket compare links. #65

merged 2 commits into from
Oct 8, 2018

Conversation

Jule-
Copy link
Contributor

@Jule- Jule- commented Oct 8, 2018

In order to work, % char should be escaped in compare link.

@Jule-
Copy link
Contributor Author

Jule- commented Oct 8, 2018 •
edited
Loading

Finally I've found that .. works with bitbucket so I changed to that notation.

@cookpete
Copy link
Owner

cookpete commented Oct 8, 2018

Nice one @Jule- – I don't think .. worked when I first wrote the library but it's good to know it does now.

Does it work with three dots ... also? If so we could remove that if branch completely.

@cookpete
Copy link
Owner

cookpete commented Oct 8, 2018

Just had a look myself and looks like it has to be .. – Never mind!

@cookpete cookpete merged commit 2b4aa45 into cookpete:master Oct 8, 2018
@Expoverse Expoverse mentioned this pull request Aug 27, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Jule- @cookpete