Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API proposal #6

Closed
cooldogedev opened this issue Oct 2, 2021 · 7 comments
Closed

API proposal #6

cooldogedev opened this issue Oct 2, 2021 · 7 comments
Assignees
Labels

Comments

@cooldogedev
Copy link
Member

implement a more simplified API for plugin developers or maybe just use singleton for the main class

@cooldogedev cooldogedev added Type: Proposal Proposal of a feature or request help wanted labels Oct 2, 2021
@KygekDev
Copy link
Contributor

Agree

@cooldogedev cooldogedev self-assigned this Oct 24, 2021
cooldogedev pushed a commit that referenced this issue Oct 24, 2021
temporary solution for plugin developers (already discussed in #6)
@SOF3
Copy link
Contributor

SOF3 commented Dec 9, 2021

Since you're doing singleton anyway, why not just make all the API methods static?

@cooldogedev
Copy link
Member Author

Since you're doing singleton anyway, why not just make all the API methods static?

The reason behind that is i was trying to not violate OOP as much as I could. I'm thinking of having an API entry/class (wrapper for the existing methods) to use static methods.

@SOF3
Copy link
Contributor

SOF3 commented Dec 9, 2021

Using static methods doesn't violate OOP.

I mean, if you want to keep the API simple, simply expose a static method and fetch the singleton inside the implementation.

@SOF3
Copy link
Contributor

SOF3 commented Dec 21, 2021

Any updates?

This plugin will likely get featured on Poggit, but only if it has a proper, simple API intended for external users.

@cooldogedev
Copy link
Member Author

Any updates?

This plugin will likely get featured on Poggit, but only if it has a proper, simple API intended for external users.

Yeah there is update on my local machine, I'll push them after doing some final testing tonight.

@cooldogedev
Copy link
Member Author

8ce1f9b has introduced the following class it is the simplified version of the API for plugin developers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants