Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

billing sample data #17

Merged
merged 22 commits into from
Jun 30, 2021
Merged

billing sample data #17

merged 22 commits into from
Jun 30, 2021

Conversation

michaelkamphausen
Copy link
Member

No description provided.

@michaelkamphausen
minor fixes
6317172
@michaelkamphausen
added sample billing data and tests for generating billing payload fi…
10964ab 
…les (#7)
@michaelkamphausen
included Sondertarife, changed order of clients (Versicherte) and cha…
ad55904 
…nged one name to include special characters
@michaelkamphausen
fixed invoice numbers and name of invoicing party in case it is an cl…
17d64f9 
…earing office with authority to collect
@michaelkamphausen
reordered sample data
889911c
@michaelkamphausen
fixed wrong Leistungsart codes in sample data
b38a08f
@michaelkamphausen
sort Einsätze and Leistungen by date; Einsatz start date has become o…
a7b3b7f 
…ptional; more precise dates in sample data
@michaelkamphausen
always write leistungsBeginn in ESK segment and ignore Vergütungsart,…
9dccdc3 
… therefore stopping to create a ESK segment for each Leistung with a different Vergütungsart
@michaelkamphausen
made Leistungsbeginn optional for ESK segment
c439c86
@michaelkamphausen
fixed grouping of Abrechnungsfälle by Leistungsart
1e8c96e
@michaelkamphausen
fixed eindeutige Belegnummer for INV segment which can be calculated …
5c36758 
…from an index
@michaelkamphausen
fixed eindeutige Belegnummer for INV segment which can be calculated …
6185426 
…from an index
@michaelkamphausen
fixed iterating Rechnungsnummer
ecbffcb
@michaelkamphausen
fixed invoice amounts calculation for IAF and GES segments
225b6d5
@michaelkamphausen
fixed grouping of accounting month: one INV segment per accounting mo…
ac633d2 
…nth and one MAN segment per INV
@michaelkamphausen
refactored absenderIK and rechnungsstellerIK
03abd5b
@michaelkamphausen
fixed length of Institutionskennzeichen in sample data: 9 digits inst…
0f41ceb 
…ead of 10
@michaelkamphausen michaelkamphausen mentioned this pull request May 20, 2021
Merged
@michaelkamphausen
Merge branch 'main' into payload-sampledata
e03fe2f 
# Conflicts:
#	package.json
#	tsconfig.json
@michaelkamphausen
validate payload data before converting them to SGB XI Nutzdaten, plu…
9efe475 
…s some fixes for minor mistakes found by validation
@michaelkamphausen
Copy link
Member Author

Closes #7 and #9.

@michaelkamphausen
Copy link
Member Author

Also includes payload data validation according to #18, but only for SGB XI yet.

@michaelkamphausen michaelkamphausen marked this pull request as ready for review June 28, 2021 08:20
westnordost
westnordost reviewed Jun 28, 2021
View reviewed changes
src/sgb-xi/index.ts Outdated Show resolved Hide resolved
src/sgb-xi/index.ts Outdated Show resolved Hide resolved
src/sgb-xi/validation.ts Show resolved Hide resolved
src/types.ts Show resolved Hide resolved
tests/validation.spec.ts Show resolved Hide resolved
@michaelkamphausen
Copy link
Member Author

Thank you for reviewing! Do you approve the PR with my changes and answers?

@westnordost
Copy link
Contributor

westnordost commented Jun 30, 2021 •
edited
Loading

Maybe one thing, I figure that could be done later. You have some utility functions like forEachKostentraeger and something like that, but those return a result. I wouldn't expect a function named like that to return a result. Depending on what the function does exactly, maybe map(Each)Kostentraeger would fit better?

@michaelkamphausen
Copy link
Member Author

michaelkamphausen commented Jun 30, 2021 •
edited
Loading

I see your point. Okay, let's call it mapEachKostentraeger. I know the name was misleading and I chose it to align the lines 54 – 64 with the documentation on pages 12 - 14, but I think mapEach… is better now.

@michaelkamphausen michaelkamphausen merged commit 6929bde into main Jun 30, 2021
@michaelkamphausen michaelkamphausen deleted the payload-sampledata branch June 30, 2021 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@westnordost westnordost westnordost approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@michaelkamphausen @westnordost