Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove bundle inheritance #33

Closed
theMadness opened this issue Nov 13, 2018 · 3 comments
Closed

Remove bundle inheritance #33

theMadness opened this issue Nov 13, 2018 · 3 comments

Comments

@theMadness
Copy link

theMadness commented Nov 13, 2018 •
edited
Loading

Would it be possible to remove bundle inheritance so it can be compatible with symfony 4?
@theMadness theMadness changed the title symfony 4 Remove bundle inheritance Nov 13, 2018
@dunglas
Copy link
Member

dunglas commented Nov 13, 2018

If someone work on this, we will be glad to merge the PR. Unfortunately SF4 compatibility for this bundle is not on our own agenda right now.

@theMadness
Copy link
Author

Definitely not opposed to work on it, can you give a few pointers/a todo list? I'm not too versed in how to update bundles.

@dunglas
Copy link
Member

dunglas commented Nov 20, 2018

I think you can just provide a Pull Request with you changes, and we'll review them

@dFayet dFayet mentioned this issue Jan 5, 2019
Merged
@dunglas dunglas closed this as completed Apr 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@dunglas @theMadness