Add Compatibility for Symfony 4 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 5, 2019 16:18
|
Great, thanks. You can force to upgrade to admin-bundle 3.40+, in the same PR. |
|
Here you go, and doc updated as well. Edit:I updated the doc to use FOSCkeditor in place of IvoryCkeditor as ivory is no more actively developed |
dunglas
approved these changes
Jan 6, 2019
|
@dFayet please see also this comment #32 (comment) |
|
Hi @memboc this PR fixes your comment. Using the parameter sonata.media.admin.media.controller allow us to override the sonata-media MediaAdminController, and so we do not need to rewrite the routes manually. The others points are also corrected. |
|
@dunglas Is there anything I can do to make this PR mergeable? |
|
Could someone merge this PR, I need theses changes to upgrade my SF4 project ? |
|
Thanks @dFayet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Compatibility for Symfony 4 and should fix issues #32 and #33
I'm not sure if this is the best solution, tell me if you have an other idea.
If you are ok with this solution I will update the install doc.
On an other note on sonata-project/admin-bundle 3.40 they have removed the inlined js used in the layout.html.twig, and replaced it with a meta attribute. This make the bundle not working with version > 3.40, do you want us to force to recent version, and update the layout.html.twig? And if yes, should I do it in this PR or in an other?