-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Compatibility for Symfony 4 #34
Conversation
Great, thanks. You can force to upgrade to admin-bundle 3.40+, in the same PR. |
Here you go, and doc updated as well. Edit:I updated the doc to use FOSCkeditor in place of IvoryCkeditor as ivory is no more actively developed |
@dFayet please see also this comment #32 (comment) |
Hi @memboc this PR fixes your comment. Using the parameter sonata.media.admin.media.controller allow us to override the sonata-media MediaAdminController, and so we do not need to rewrite the routes manually. The others points are also corrected. |
@dunglas Is there anything I can do to make this PR mergeable? |
Could someone merge this PR, I need theses changes to upgrade my SF4 project ? |
Thanks @dFayet |
This PR adds Compatibility for Symfony 4 and should fix issues #32 and #33
I'm not sure if this is the best solution, tell me if you have an other idea.
If you are ok with this solution I will update the install doc.
On an other note on sonata-project/admin-bundle 3.40 they have removed the inlined js used in the layout.html.twig, and replaced it with a meta attribute. This make the bundle not working with version > 3.40, do you want us to force to recent version, and update the layout.html.twig? And if yes, should I do it in this PR or in an other?