fix: introduce TokenGenerator #140
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
vincentchalamon
commented
May 23, 2024
vincentchalamon
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | Fixes #137 |
| License | MIT |
vincentchalamon
changed the title
vincentchalamon
force-pushed
the
feat/token-generator
branch
3 times, most recently
from
0379f71
to
75f66cf
Compare
vincentchalamon
force-pushed
the
feat/token-generator
branch
from
75f66cf
to
03dca8e
Compare
|
@aynaitlamine What do you think of this one? You can try it with the following installation: composer require tilleuls/forgot-password-bundle:dev-feat/token-generatorCheck the PR files for documentation and usage. Thanks for your feedback! |
|
Hi @vincentchalamon, Thank you for the response and the implementation! I followed the documentation and usage instructions provided in the PR, and I'm happy to report that it works perfectly for generating a 6-digit numeric token. Thank you for addressing this feature request so efficiently. I appreciate your help and the quick turnaround! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.