Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functional version php8 #62

Closed

Conversation

JulieNobody
Copy link
Contributor

@JulieNobody JulieNobody commented Feb 28, 2022

version fonctionnelle pour PHP 8

vendor/bin/phpunit en local : pas d'erreur

tests de GitHub action en local : pas d'erreur

tests de GitHub action sur GitHub : erreurs
(vu avec Antoine B., visiblement il s'agit d'un problème lié à Node Sass qui ne build pas)

Copy link
Member

@dunglas dunglas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job!

The ChromeDriver and Gecko driver binaries must not be committed (add them to .gitignore).

composer.json Show resolved Hide resolved
tests/Application/config/packages/doctrine.yaml Outdated Show resolved Hide resolved
@JacquesDurand JacquesDurand mentioned this pull request Nov 30, 2022
@mathieu-dumoutier
Copy link

Hi!

Have you the intention to finish this PR?

Thank you for your answer

@romainallanot
Copy link
Contributor

closed this as merged in #68

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants