Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Miss an use in RestrictedDiet class #41

Closed
clementtalleu opened this issue Aug 23, 2017 · 3 comments
Closed

Miss an use in RestrictedDiet class #41

clementtalleu opened this issue Aug 23, 2017 · 3 comments

Comments

@clementtalleu
Copy link
Contributor

The annotation @ApiResource is used in the RestrictedDiet php class but without the call to the vendor's class : use ApiPlatform\Core\Annotation\ApiResource; it will crash
Atala added a commit that referenced this issue Aug 23, 2017
@Atala
fix: typos
2d2c711 
F*x #41
F*w #40
@Atala
Copy link
Member

Atala commented Aug 23, 2017

How did you find theses (#40, #41) ? Static analysis?

@clementtalleu
Copy link
Contributor Author

I just read some classes and my IDE did the job.

But I think that install https://github.com/phpstan/phpstan will be a good idea, then travis to prevent merging bad coding style or php errors

@clementtalleu clementtalleu mentioned this issue Aug 23, 2017
Closed
@alexsegura
Copy link
Member

Fixed in 94b3f6e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@alexsegura @Atala @clementtalleu