Associate existing users as business accounts employees #4253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucasferraro
changed the title
Atala
approved these changes
May 14, 2024
There was a problem hiding this comment.
hello lucas
it works as expected but I think the UI could be slightly improve, because the "yellow notif" which leads you to login is not enough visible i think (i was focus on the error message)
it should be written closer to the error message, maybe in the same text string as the error message if possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With these changes now an existing user should be able to accept the invitation to associate its account to a Business Account (#4251).
An existing user opens the link of the invitation while they are not logged in to the platform
not-logged-in.mp4
An existing and logged in user opens the link of the invitation
logged-in.mp4