New reports with full data of users, posts, transfers #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
enricostano
reviewed
Aug 14, 2017
| else | ||
| '' | ||
| end | ||
| end |
There was a problem hiding this comment.
def nil_to_empty(field)
return '' unless field
field.to_formatted_s(:db)
end
enricostano
approved these changes
Aug 14, 2017
| <%= t "application.navbar.tags" %> | ||
| <% end %> | ||
| </li> | ||
| <li> |
| <thead> | ||
| <tr> | ||
| <!-- %th= User.human_attribute_name(:registration_number) | ||
| --> |
|
@sauloperez I need help with all transfer report |
|
Ok, I'll take this one over. But it might take me a while to get to it. |
sseerrggii
force-pushed
the
feature/new-reports
branch
from
ec47a47
to
ca82ecf
Compare
|
Almost a year later ... I finished! Code review please! Be kindly please ❤️ |
sauloperez
approved these changes
Apr 26, 2018
There was a problem hiding this comment.
I see quite a lot of easy-to-spot duplication but that's not a big deal now. Pretty good @sseerrggii 👏
| def user_complete_list | ||
| @members = current_organization.members.active. | ||
| includes(:user). | ||
| order("members.member_uid") |
There was a problem hiding this comment.
I would stick to either multiline or single line but not both styles.
| active. | ||
| includes(:user, :category). | ||
| to_a. | ||
| sort_by { "posts.id" } |
| @transfers = current_organization.all_transfers. | ||
| includes(movements: {account: :accountable}). | ||
| order("transfers.created_at DESC"). | ||
| uniq |
| <thead> | ||
| <tr> | ||
| <!-- %th= User.human_attribute_name(:registration_number) | ||
| --> |
|
@sseerrggii 👏 👏 👏 You "only" need to add tests... |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Permite crear nuevos reports de usuarios, posts y transferencias con toda la información relevante de la base de datos para administradores.
Posts y Transfers deben ir relacionados con member uid para poder hacer las relaciones.