Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SGE script config #1044

Merged
merged 5 commits into from
Nov 24, 2015
Merged

Conversation

btovar
Copy link
Member

@btovar btovar commented Nov 20, 2015

Fixes #1040 (bugs and taxes!)

Adds --sge-parameter to configure, which can be used several times.
Prints a warning when resources are manually specified.
Uses the old options in configure.afs.

@nhazekam

./configure --sge-parameters='-pe smp $cores'

creates sge_submit_workers with

 #$ -pe smp $cores

in the worker submission script.

--sge-parameters could be used several times at the command line. Each
time specifies a line that should be copied at the top of
sge_submit_workers.

For Notre Dame, ./configure.afs has --sge-parameters='-pe smp $cores'.

if [ $specified_resources = 1 -a $SGE_WARNING = 1 ]
then
echo "Worker resources were manually specified. Remember to also describe your resources according to your local qsub system (e.g., -p '-pe smp 4'. See also the --sge-parameter configuration option.)" 1>&2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggest that you explicitly name the "configure" script here, otherwise it may not be clear to the user.
Also add an item to the Makeflow manual explaining in more detail.

@btovar btovar modified the milestones: 5.3, 5.4 Nov 23, 2015
btovar added a commit that referenced this pull request Nov 24, 2015
@btovar btovar merged commit b2b9a2c into cooperative-computing-lab:master Nov 24, 2015
@btovar btovar deleted the sge_config branch November 24, 2015 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants