Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prometheus is a bit overkill for my use case, so I was wondering if you'd be interested in adding a more simple metrics option. Basically, if the user provides a non-empty URL, gickup makes a
GET
request to the URL after each backup. I totally understand if this seems like an unecessary feature though. Similar functionality can already be accomplished by using your own scheduling method and making the request with CURL if gickup exited successfully, though this feels kind of hacky too since scheduling is already built-in.If you're interested in adding this feature, I had one implementation question: should I make the config section a mapping with a
url
key so we can expand it without breaking changes if neccessary (though I can't think of how we'd need to), or should I just makeheartbeat
a string that takes the url?