-
-
Notifications
You must be signed in to change notification settings - Fork 173
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for yaml data files #1059
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, @Ian2012!
I have a couple of minor suggestions and raised a topic for discussion around repeatedly passing the -d, --data
switch with data files.
Please also add tests for both the success and failure scenarios once the conceptual discussion has been resolved.
As always, @yajo needs to perform the ultimate review, I'm only trying to support.
@sisp Thanks for your review. I've already handle all your comments, if you agree, could you resolve all the conversations so we can focus on the conceptual discussion? |
Thanks, @Ian2012. There are still a few open suggestions of mine in the docs though. And I can't seem to mark the other comments as resolved. Can you resolve them? |
Is there anything I can do to speed up the review process? |
Codecov Report
@@ Coverage Diff @@
## master #1059 +/- ##
==========================================
- Coverage 96.49% 96.09% -0.40%
==========================================
Files 44 43 -1
Lines 3394 3203 -191
==========================================
- Hits 3275 3078 -197
- Misses 119 125 +6
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 10 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
@Ian2012 I think it would be good to mention in the docs for both |
I totally agree, here is an updated version https://copier--1059.org.readthedocs.build/en/1059/configuring/#data |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some rewording on docs and simplification on code.
Thanks for the feature! Really helpful and a small patch. I like it a lot 😊
This needs a test though. Could you add it too please?
Co-authored-by: Jairo Llopis <973709+yajo@users.noreply.github.com>
Co-authored-by: Jairo Llopis <973709+yajo@users.noreply.github.com>
Co-authored-by: Jairo Llopis <973709+yajo@users.noreply.github.com>
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
Co-authored-by: Sigurd Spieckermann <2206639+sisp@users.noreply.github.com>
Co-authored-by: Jairo Llopis <973709+yajo@users.noreply.github.com>
docs/configuring.md
Outdated
- CLI flags: `--data-file` | ||
- Default value: N/A | ||
|
||
As an alternative to [`--data`][data] you can also pass the path to a YAML file that contains your data. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newline is missing. Also, how about adding the short flag here as well? And shouldn't the link be an anchor link?
As an alternative to [`--data`][data] you can also pass the path to a YAML file that contains your data. | |
As an alternative to [`-d, --data`](#data) you can also pass the path to a YAML file that contains your data. | |
docs/configuring.md
Outdated
- Default value: N/A | ||
|
||
As an alternative to [`--data`][data] you can also pass the path to a YAML file that contains your data. | ||
!!! info |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A newline is missing:
!!! info | |
!!! info | |
I would like to add tests but I'm unable to setup a development environment using local env, do you guys have the manual instructions? When I run |
There's a small guide in https://github.com/copier-org/copier/blob/master/CONTRIBUTING.md#dev-environment-setup The fastest way is just to use gitpod. |
@yajo I'm really struggling with the test, could you give me a hand there? I'm not used to test |
@Ian2012 If you're still struggling with setting up the development environment, it's typically sufficient to run $ poetry install --with dev,docs
$ poetry run pip install black isort # optionally but useful to get the formatters
$ poetry run poe test if you have Git and a sufficiently recent Python interpreter installed on your system. Nix provides a complete and deterministic setup including Git, Python, pre-commit, code formatters and linters, but you should be able to develop also without it. |
I think it's more a matter of not knowing how to do a unit test, right? I'll try to help when I have some free time. Or maybe you can help with that @sisp? |
Superseded by #1325. |
This PR adds support for yaml files as a data input