Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

escaping with %-escaped query string #31

Closed
no6v opened this issue Jul 23, 2011 · 3 comments
Closed

escaping with %-escaped query string #31

no6v opened this issue Jul 23, 2011 · 3 comments
Assignees
@copiousfreetime
Labels
bug

Comments

@no6v
Copy link

no6v commented Jul 23, 2011 

$ ruby -rlaunchy -ve '
p Launchy::VERSION
Launchy.open("http://ja.wikipedia.org/wiki/%E3%81%82", :dry_run => true)
'
ruby 1.9.2p290 (2011-07-09 revision 32553) [x86_64-linux]
"2.0.3"
/usr/bin/xdg-open http://ja.wikipedia.org/wiki/\%E3\%81\%82

And this really opens http://ja.wikipedia.org/wiki//%E3/%81/%82 .
At least version "0.4.0", it opened intended URL.
@ghost ghost assigned copiousfreetime Jul 23, 2011
copiousfreetime added a commit that referenced this issue Jul 23, 2011
@copiousfreetime
Fix when and where shell escaping is to be done.
1548e33 
* fixes #31
@copiousfreetime
Copy link
Owner

This should be fixed now, and you can also use the utf8 string directly. See #32

@no6v
Copy link
Author

no6v commented Jul 24, 2011

I updated launchy gem to "2.0.4" and it works fine, thanks!

@copiousfreetime
Copy link
Owner

Glad to help. Please let me know if you find any other bugs.

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Aug 12, 2011
Update misc/ruby-launchy package to 2.0.5.
f194abd 
== Version 2.0.5 - 2011-07-24

* Fix the case where $BROWSER is set and no *nix desktop was found
  (copiousfreetime/launchy#33)

== Version 2.0.4 - 2011-07-23

* Fix windows 'start' commandline (copiousfreetime/launchy#5)
* Add capability to open local files with no file: scheme present
  (copiousfreetime/launchy#29)
* Added 'rake how_to_contribute' task (copiousfreetime/launchy#30)
* Make better decisions on when to do shell escaping
  (copiousfreetime/launchy#31)
* Switch to Addressable::URI so UTF-8 urls may be
  parsed. (copiousfreetime/launchy#32)

== Version 2.0.3 - 2011-07-17

* Add in Deprecated API wrappers that warn the user

== Version 2.0.2 - 2011-07-17

* Typo fixes from @mtorrent
* Documentation updates explicitly stating the Public API
* Increase test coverage

== Version 2.0.1 - 2011-07-16

* Almost a complete rewrite
* JRuby Support
* Organization is such that it will be easier to add additional applications
* Windows behavior possibly fixed, again

== Version 1.0.0 - 2011-03-17

* Add JRuby support (Stephen Judkins)
* Remove unused Paths module
* Switch to using bones
* Switch to use minitest
* NOTE, this version was never released.
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Oct 11, 2014
Update misc/ruby-launchy package to 2.0.5.
babcd7a 
== Version 2.0.5 - 2011-07-24

* Fix the case where $BROWSER is set and no *nix desktop was found
  (copiousfreetime/launchy#33)

== Version 2.0.4 - 2011-07-23

* Fix windows 'start' commandline (copiousfreetime/launchy#5)
* Add capability to open local files with no file: scheme present
  (copiousfreetime/launchy#29)
* Added 'rake how_to_contribute' task (copiousfreetime/launchy#30)
* Make better decisions on when to do shell escaping
  (copiousfreetime/launchy#31)
* Switch to Addressable::URI so UTF-8 urls may be
  parsed. (copiousfreetime/launchy#32)

== Version 2.0.3 - 2011-07-17

* Add in Deprecated API wrappers that warn the user

== Version 2.0.2 - 2011-07-17

* Typo fixes from @mtorrent
* Documentation updates explicitly stating the Public API
* Increase test coverage

== Version 2.0.1 - 2011-07-16

* Almost a complete rewrite
* JRuby Support
* Organization is such that it will be easier to add additional applications
* Windows behavior possibly fixed, again

== Version 1.0.0 - 2011-03-17

* Add JRuby support (Stephen Judkins)
* Remove unused Paths module
* Switch to using bones
* Switch to use minitest
* NOTE, this version was never released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@copiousfreetime copiousfreetime

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@copiousfreetime @no6v