Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UTF-8 urls cannot be launched #32

Closed
copiousfreetime opened this issue Jul 23, 2011 · 1 comment
Closed

UTF-8 urls cannot be launched #32

copiousfreetime opened this issue Jul 23, 2011 · 1 comment
Assignees
Labels

Comments

@copiousfreetime
Copy link
Owner

Found while investigating #31

A UTF-8 url passed on the command line fails to open.

http://ja.wikipedia.org/wiki/あ

LAUNCHY_DEBUG: Launchy : Failure in opening http://ja.wikipedia.org/wiki/あ with options {}: bad URI(is not URI?): http://ja.wikipedia.org/wiki/あ
LAUNCHY_DEBUG: /Users/jeremy/.rvm/rubies/ruby-1.8.7-p334/lib/ruby/1.8/uri/common.rb:436:in `split'
LAUNCHY_DEBUG: /Users/jeremy/.rvm/rubies/ruby-1.8.7-p334/lib/ruby/1.8/uri/common.rb:485:in `parse'
LAUNCHY_DEBUG: ./lib/launchy.rb:28:in `open'
LAUNCHY_DEBUG: ./lib/launchy/cli.rb:72:in `good_run'
LAUNCHY_DEBUG: ./lib/launchy/cli.rb:80:in `run'
LAUNCHY_DEBUG: bin/launchy:4
Failure in opening http://ja.wikipedia.org/wiki/あ with options {}: bad URI(is not URI?): http://ja.wikipedia.org/wiki/あ
@ghost ghost assigned copiousfreetime Jul 23, 2011
@copiousfreetime
Copy link
Owner Author

fixed with commit a568f89

jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Aug 12, 2011
== Version 2.0.5 - 2011-07-24

* Fix the case where $BROWSER is set and no *nix desktop was found
  (copiousfreetime/launchy#33)

== Version 2.0.4 - 2011-07-23

* Fix windows 'start' commandline (copiousfreetime/launchy#5)
* Add capability to open local files with no file: scheme present
  (copiousfreetime/launchy#29)
* Added 'rake how_to_contribute' task (copiousfreetime/launchy#30)
* Make better decisions on when to do shell escaping
  (copiousfreetime/launchy#31)
* Switch to Addressable::URI so UTF-8 urls may be
  parsed. (copiousfreetime/launchy#32)

== Version 2.0.3 - 2011-07-17

* Add in Deprecated API wrappers that warn the user

== Version 2.0.2 - 2011-07-17

* Typo fixes from @mtorrent
* Documentation updates explicitly stating the Public API
* Increase test coverage

== Version 2.0.1 - 2011-07-16

* Almost a complete rewrite
* JRuby Support
* Organization is such that it will be easier to add additional applications
* Windows behavior possibly fixed, again

== Version 1.0.0 - 2011-03-17

* Add JRuby support (Stephen Judkins)
* Remove unused Paths module
* Switch to using bones
* Switch to use minitest
* NOTE, this version was never released.
jsonn pushed a commit to jsonn/pkgsrc that referenced this issue Oct 11, 2014
== Version 2.0.5 - 2011-07-24

* Fix the case where $BROWSER is set and no *nix desktop was found
  (copiousfreetime/launchy#33)

== Version 2.0.4 - 2011-07-23

* Fix windows 'start' commandline (copiousfreetime/launchy#5)
* Add capability to open local files with no file: scheme present
  (copiousfreetime/launchy#29)
* Added 'rake how_to_contribute' task (copiousfreetime/launchy#30)
* Make better decisions on when to do shell escaping
  (copiousfreetime/launchy#31)
* Switch to Addressable::URI so UTF-8 urls may be
  parsed. (copiousfreetime/launchy#32)

== Version 2.0.3 - 2011-07-17

* Add in Deprecated API wrappers that warn the user

== Version 2.0.2 - 2011-07-17

* Typo fixes from @mtorrent
* Documentation updates explicitly stating the Public API
* Increase test coverage

== Version 2.0.1 - 2011-07-16

* Almost a complete rewrite
* JRuby Support
* Organization is such that it will be easier to add additional applications
* Windows behavior possibly fixed, again

== Version 1.0.0 - 2011-03-17

* Add JRuby support (Stephen Judkins)
* Remove unused Paths module
* Switch to using bones
* Switch to use minitest
* NOTE, this version was never released.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant