Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[warnings] Please fix OCaml warnings #32

Closed
ejgallego opened this issue Feb 19, 2019 · 0 comments
Closed

[warnings] Please fix OCaml warnings #32

ejgallego opened this issue Feb 19, 2019 · 0 comments

Comments

@ejgallego
Copy link
Contributor

Dear devs,

in Coq we are considering requiring plugins in the CI to use the same set of compiler flags for warnings than the main Coq tree (c.f. coq/coq#9605 ), in particular, this means that the plugins should now compile warning-free, except for deprecation notices.

Note that some of the raised warnings are really fatal, [like missing match cases].

Please, try to fix OCaml warnings present in your codebase, thanks!
@ejgallego ejgallego mentioned this issue Feb 19, 2019
Merged
ejgallego added a commit to ejgallego/aac-tactics that referenced this issue Feb 20, 2019
@ejgallego
[coq] Fix OCaml warnings.
a58710c 
They do seem pretty straightforward, most of them have to do with dead code.

Fixes coq-community#32
@ejgallego ejgallego mentioned this issue Feb 20, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@ejgallego