-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to coqpp. #13
Port to coqpp. #13
Conversation
@ppedrot Is the plan to have all plugins exclusively rely on coqpp for 8.10? |
Indeed. |
@ppedrot This PR breaks compatibility with Coq 8.9 (not surprising, but let's say the objective of keeping compatibility with two successive versions of Coq won't have lasted long) so this PR should also remove the line testing Coq 8.9 from the |
@Zimmi48 This should be ready btw. |
@ppedrot I forgot but since this is removing the dependency on camlp5, can you remove it from the |
Unluckily I have no idea about the Nix language, so please go ahead. |
Done. |
@ppedrot It turns out that the dependency on camlp5 cannot be removed without change after all:
Do you understand this error? |
I suspect that this is due to coq_makefile, that still passes the camlp5 library flags to all files it compiles. If we want a transition phase I don't know how to work around this cleanly. Maybe a flag passed to the invocation of coq_makefile? |
Well, one solution is to continue depending on camlp5 until the Coq packages are migrated to use dune instead of coq_makefile... For the sake of not blocking this PR, I suggest you force-push to this branch to remove my commit. |
Gaah. Done. |
@Zimmi48 feel free to copy and adapt the |
@Zimmi48 ok, I'm not very knowledgeable in the build infrastructure. |
No description provided.