Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New lightweight toolbox-based setup. #80

Merged
merged 1 commit into from
Aug 6, 2021
Merged

New lightweight toolbox-based setup. #80

merged 1 commit into from
Aug 6, 2021

Conversation

Zimmi48
Copy link
Member

@Zimmi48 Zimmi48 commented Aug 6, 2021

Replacement for #77.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 6, 2021

On Travis, the full build without Cache (including Coq) takes 10 to 11 minutes and it takes 12 to 13 minutes on GitHub Actions (+ about 1-2 minutes to upload the artifacts to the coq-community Cachix). Once Coq can be fetched from Cachix, the build takes less than 2 minutes (both on Travis and on GitHub Actions).

@palmskog
Copy link
Member

palmskog commented Aug 6, 2021

The Nix CI job looks good to me, I assume this is usable with 8.14 as coq_version also? Is this ready to merge? If so, let me know or just merge it yourself.

After an update to the templates, I think we should try to roll this out to all projects still using Nix CI in coq-community.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 6, 2021

The Nix CI job looks good to me, I assume this is usable with 8.14 as coq_version also?

With v8.14 yes (the name of the branch), although there will also be limitations on what Cachix artifacts are available until the adequate Coq PRs are backported. This shouldn't matter as much though, given how infrequently the v8.14 branch is updated.

With 8.14, it will work once there is an 8.14 release in nixpkgs.

Is this ready to merge?

I've finally managed to avoid the rebuild of aac-tactics if the job is restarted (the missing ingredient was to ignore the .git folder in the sources). We are now down to a 30s job when nothing has changed.
Now, I just need to force-push to remove the .travis.yml configuration, which was there only for testing (done). Then, this can be considered ready to merge, as long as you don't mind this new CI setup not being fully stable yet.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 6, 2021

After an update to the templates, I think we should try to roll this out to all projects still using Nix CI in coq-community.

There are 26 repositories with a default.nix file but only 3 with a nix-action.yml file (aac-tactics, chapar and huffman) + 1 with a nix-ci.yml file (pocklington). For the rest, we should just remove the legacy default.nix file.

@palmskog
Copy link
Member

palmskog commented Aug 6, 2021

I'm fine with an experimental setup if it gives CI running times of less than 10 minutes. I will do some testing on some other projects and then merge later tonight.

@palmskog palmskog merged commit 3f9ddc4 into master Aug 6, 2021
@palmskog palmskog deleted the new-nix-setup branch August 6, 2021 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants