Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adapt the various "Let" ended with Qed #82

Conversation

herbelin
Copy link
Contributor

In sections: use #[clearbody] and Defined instead (see coq/coq#17205)
At toplevel: use Local Lemma instead

Assuming that this was the intended correction.

In sections: use #[clearbody] and Defined instead
At toplevel: use Local Lemma instead
@herbelin herbelin changed the title Adapt the various "Let" with Qed Adapt the various "Let" ended with Qed Oct 30, 2023
@proux01 proux01 merged commit 97b7251 into coq-community:master Oct 30, 2023
1 check passed
@proux01
Copy link
Collaborator

proux01 commented Oct 30, 2023

Thnaks!

As you've seen we currently have coq/coq#17576 which IMHO would be the perfect solution to all that mess, at least the way it is used in the mathcomp world.

@herbelin
Copy link
Contributor Author

herbelin commented Oct 30, 2023

As you've seen we currently have coq/coq#17576 which IMHO would be the perfect solution to all that mess, at least the way it is used in the mathcomp world.

Is there a summary of the situation somewhere (problems and solutions)? I'm lost in all the discussions.

@proux01
Copy link
Collaborator

proux01 commented Oct 30, 2023

Maybe the last two messages: coq/coq#17576 (comment)

@herbelin
Copy link
Contributor Author

Maybe the last two messages: coq/coq#17576 (comment)

I was thinking at a summary of the issues with Let (what to do with Admitted, #16893; effect of Qed on context initialization of other theorems, ...). In particular, I wonder if we would not save the burden of abstract and of having to address the warning by keeping Let as it is but letting its opacity have an impact (by uniformity of behavior) on other declarations of the context. Would there be a known problem at doing so?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants