Generalize seqmx.v to not require a ringType structure everywhere. #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This can be useful for example, to manipulate matrices of floating-point values, as floating-point arithmetic does not have a ring structure (addition is not even associative). Actually, the ring structure on the coefficients is definitely overkill for all non arithmetic operations over matrices.
|
@CohenCyril Could you reply to those PRs? They've been dormant for a while now. Thanks! |
|
integrated |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
Pierre Roux and I prepared this PR after working on our library validsdp.
This generalization can be useful for example, to manipulate matrices of floating-point values, as floating-point arithmetic does not have a ring structure (addition is not even associative). Actually, the ring structure on the coefficients is definitely overkill for all non arithmetic operations over matrices.
Note that we only tested this version with paramcoq-dev~1 (i.e., bc9e61d) because of a compilation issue related to math-comp/math-comp#62
Kind regards,
Erik and Pierre