Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dump.ml does not compile anymore #123

Closed
gares opened this issue Aug 20, 2020 · 9 comments
Closed

dump.ml does not compile anymore #123

gares opened this issue Aug 20, 2020 · 9 comments

Comments

@gares
Copy link
Contributor

gares commented Aug 20, 2020

since it was written 10 years ago ;-)

@spitters
Copy link
Collaborator

What would go into getting it to work again? @VincentSe has a cool application in mind.

@VincentSe
Copy link
Collaborator

VincentSe commented Aug 29, 2020

@gares @spitters According to the documentation
https://coq.github.io/doc/master/refman/practical-tools/utilities.html
The VERNAC EXTEND must be in a mlg file for preprocessing, so dump.ml cannot work anymore.

@spitters
Copy link
Collaborator

This should now be rewritten as a plugin, which I hope would not be too difficult.

@gares
Copy link
Contributor Author

gares commented Aug 29, 2020

This is a small totorial for writing plugins: https://github.com/coq/coq/tree/master/doc/plugin_tutorial

@VincentSe
Copy link
Collaborator

VincentSe commented Aug 29, 2020

@spitters @gares Indeed, we can run the ocaml compiler by putting dump.ml inside g_tuto0.mlg. And we then see multiple errors

  • modules Topconstr, Pretyping.Default and Tactic no longer exist
  • pp function names changed, I am not sure which ones to call now
  • Reductionops changed, I tried rewriting it by this (Reductionops.nf_all env Evd.empty c) but it fails with This expression has type (EConstr.constr -> Tacticals.tactic) -> Tacticals.tactic but an expression was expected of type EConstr.constr = Evd.econstr. I have no clue what that means.

@gares
Copy link
Contributor Author

gares commented Aug 29, 2020

If you publish your wip branch I can look at it.

@VincentSe
Copy link
Collaborator

@gares Here is the branch
https://github.com/coq-community/corn/tree/FixDump
At the moment it is just a copy of tuto0 into dump. The code in dump.ml was moved into g_tuto0.mlg, type make in folder dump to build and see the errors. I'll rename tuto0 when it compiles and works.

@VincentSe
Copy link
Collaborator

Hello @gares, did you look at the branch I sent you ?

@gares
Copy link
Contributor Author

gares commented Sep 7, 2020

Sorry I was on VAC. I see you merged the branch, cool!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants