Remove conditional from configure.sh #197
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The conditional doesn't work in all bashes (doesn't work in mine, GNU bash, version 5.2.15(1)-release (x86_64-pc-linux-gnu) Moreover we don't even support versions of Coq that low anymore, so there's no need.
This reverts commit 09f7719. It seems that older versions of Coq do not have these modules and therefore this is a breaking change. I do not know why CI didn't catch this.
|
Comment--this also contains a fix for a breaking commit, which I introduced to the repo. I am not sure how the checks for pull requests didn't halt this but they apparently can be fooled. |
This reverts commit 7e39c78. Nat.Div0 modules are too modern for versions of Coq 8.16 and below.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The conditional doesn't work in all bashes (doesn't work in mine, GNU bash, version 5.2.15(1)-release (x86_64-pc-linux-gnu)
Moreover we don't even support versions of Coq that low anymore, so there's no need.