[movies] Simplify the driver #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 28, 2021
Closed
|
I pushed the same commit as on top of #67 to test the latest |
|
Looks nice ! |
|
Yes, to merge this PR and #67, there are two options:
|
cpitclaudel
force-pushed
the
simple_driver
branch
from
2ab0b1e
to
32fee29
Compare
Closed
|
Something I've just noticed is that ever since this PR, the "Build Alectryon snippets" step in the build-doc job does nothing and all the snippet building is actually done in the "Compile LaTeX document" step. I don't really understand why that would be the case given that the |
This was referenced Sep 20, 2021
Thanks for catching that, fixed in #84 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #70
With the change that I suggested there, I was able to refactor the movies script into a standard Alectryon pipeline, with just a few custom actions to isolate snippets in the source
.vfile.@Casteran I tried to make a minimally invasive patch, so I didn't touch the source files. Instead I just made the code look for existing
(*| .. coq:: …flags… |*)annotations and propagate the corresponding flags.I kept the folder structure, and AFAICT the only differences are spaces; I hope I didn't miss anything (I made it so that spaces before and after snippets get stripped (which is a bit tricky due to
(*| .. coq |*)visibility annotations).This pipeline doesn't go through reST at all.
(*| .. coq |*)visibility annotations outside of snippets are ignores. Visibility settings get reset after each snippet, so(*||*)can be useful in the middle of a snippet but is not needed at the end of a snippet.The syntax
(* begin snippet ABC:: …flags… *)is supported but not used (to avoid a larger diff than necessary.@Zimmi48 I need your help to pull the latest Alectryon.