added group tactic and automated some proofs in groups.v #100
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spitters
reviewed
Jun 5, 2021
|
Thanks. Looks good. |
|
I updated the group tactic to use easy instead of firstorder, and updated the proofs as necessary. |
|
LGTM. Shall I merge? |
|
I think so!
…________________________________
From: Bas Spitters ***@***.***>
Sent: Thursday, June 10, 2021 3:37:50 AM
To: coq-community/math-classes ***@***.***>
Cc: Michael David George ***@***.***>; Author ***@***.***>
Subject: Re: [coq-community/math-classes] added group tactic and automated some proofs in groups.v (#100)
LGTM. Shall I merge?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub<#100 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AAJ2CMOBFAWIRRTO4IDE2TLTSBTU5ANCNFSM46BTNFDQ>.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I created a group_simplify tactic that simplifies group expressions by first pushing group morphisms and negations all the way down to the leaves, and then cancels out multiple negations, inverses, and mon_unit. I used this tactic to simplify and automate the proofs of several lemmas in groups.v.
This is my first serious attempt at writing new proof automation, so feedback would be appreciated.