make compilation work for coq <= 8.10 #102
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On older coqc versions, lia will go into an infinite loop here if there is confusing stuff in the context. So we clean up the context a little in order to get backwards compatibility.
13 tasks
larsr
referenced
this pull request
in NixOS/nixpkgs
Jul 10, 2021
coqc versions 8.6 - 8.10 seem unable to compile theory/monioid_normalizaition.v without going into an infinite memory-eating loop.
|
Should we restore compatibility testing with older versions? |
|
Yes, why not? |
|
Yeah, I also think it would be worthwhile, at least until we need to drop compatibility with old versions again. I will take care of this. See #103 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On older coqc versions, lia will go into an infinite loop here
if there is confusing stuff in the context. So we clean up
the context a little in order to get backwards compatibility.
With this patch, different coq versions can use the same
version of the math-classes library.
It would for instance make obsolete this suggested patch to the nix-file
NixOS/nixpkgs@fdfbe86