Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add minimal Proof using annotations modulo Set Default Proof Using #17

Merged
merged 2 commits into from
Oct 1, 2020

Conversation

palmskog
Copy link
Member

This commit adds Set Default Proof Using commands in all files with sections, and minimal Proof using annotations to include section hypotheses. This has the following results:

  • documents whenever a section hypothesis (in Prop) is used in a proof, as per recent guidelines
  • makes it worthwhile to use make vio or make vos on the project (build time is nearly halved)

Finally, I added one missing Proof and removed a redundant Proof, discoveries that were made on the way.

@palmskog palmskog requested a review from chdoc September 30, 2020 22:40
@chdoc
Copy link
Member

chdoc commented Oct 1, 2020

I think that if everything in a section depends on a section hypothesis, then it it preferable to state this once (via Local Set Proof Using) rather than have this said again and again, possibly leading to over-length one-line proofs. For mult-line proofs this is less of an issue, because there is plenty of space after the Proof. I pushed what I had in mind, are you okay with that? (I also removed count_nseq which is indeed in mathcomp since at least 1.9.0, albeit with a slightly more general type.)

@palmskog
Copy link
Member Author

palmskog commented Oct 1, 2020

Your changes look fine to me, feel free to merge.

@chdoc chdoc merged commit 39b75d2 into master Oct 1, 2020
@chdoc chdoc deleted the add-proof-using branch October 1, 2020 09:26
@chdoc chdoc mentioned this pull request Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants