Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Something is wrong with https://coq.inria.fr/refman #124

Closed
Zimmi48 opened this issue Aug 29, 2019 · 9 comments
Closed

Something is wrong with https://coq.inria.fr/refman #124

Zimmi48 opened this issue Aug 29, 2019 · 9 comments
Labels

Comments

@Zimmi48
Copy link
Member

Zimmi48 commented Aug 29, 2019

As notice by @kyoDralliam, https://coq.inria.fr/refman seems to be displayed without any CSS, whereas https://coq.inria.fr/refman/ looks good.

Note that the same is true for https://coq.inria.fr/distrib/current/refman vs https://coq.inria.fr/distrib/current/refman/. Unfortunately, it is to the former that the official website points so it is likely that people are going to encounter the problem soon. I'm going to push a commit adding the trailing dot to the links as a temporary workaround.

@Zimmi48 Zimmi48 added the bug label Aug 29, 2019
Zimmi48 added a commit to Zimmi48/www that referenced this issue Aug 29, 2019
@kyoDralliam
Copy link

I think the "real issue" is rather that all links on the page return a 404 (that's probably the reason there is no displayed CSS).

@Zimmi48
Copy link
Member Author

Zimmi48 commented Aug 30, 2019

OK, indeed. Because of this missing /, the relative links are all interpreted relative to https://coq.inria.fr/distrib/current/ instead of being relative to https://coq.inria.fr/distrib/current/refman/, which makes them 404.
The bug was not there before because of a (visible) redirection from e.g. https://coq.inria.fr/distrib/V8.9.0/refman to https://coq.inria.fr/distrib/V8.9.0/refman/. @maximedenes Would it be possible to emulate the same thing?

@maximedenes
Copy link
Member

I think so. What kind of redirection do you want?

@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 3, 2019

@maximedenes If this is not too hard to set up, I think this should get quite a high priority. Until a few days ago, the URL without the ending slash was the one that was linked to from the main page of the website. It is not unlikely that some users have saved this URL in their bookmarks.

@maximedenes
Copy link
Member

@maximedenes
Copy link
Member

301?

@maximedenes
Copy link
Member

Ok, in fact I didn't have to add a redirection, there was already one. It was simply masked by the reverse proxy. Now fixed.

@Zimmi48
Copy link
Member Author

Zimmi48 commented Sep 3, 2019

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants