Skip to content

Commit

Permalink
Merge PR #18550: Don't commit symlinks in the repository (test-suite …
Browse files Browse the repository at this point in the history
…library_attributes)

Reviewed-by: proux01
Co-authored-by: proux01 <proux01@users.noreply.github.com>
  • Loading branch information
coqbot-app[bot] and proux01 committed Feb 5, 2024
2 parents 66815d5 + 76180e5 commit 1bf8d81
Show file tree
Hide file tree
Showing 9 changed files with 11 additions and 12 deletions.
3 changes: 1 addition & 2 deletions test-suite/Makefile
Expand Up @@ -346,8 +346,7 @@ unit-tests/%.ml.log: unit-tests/%.ml unit-tests/src/$(UNIT_LINK)
# Other generic tests
#######################################################################

# There is a dependency between those two files
prerequisite/library_attributes_require.v.log: prerequisite/library_attributes.v.log
prerequisite/requires_deprecated_library.v.log: prerequisite/deprecated_library.v.log

$(addsuffix .log,$(wildcard prerequisite/*.v)): %.v.log: %.v
@echo "TEST $< $(call get_coq_prog_args_in_parens,"$<")"
Expand Down
2 changes: 1 addition & 1 deletion test-suite/output/library_attributes_require.out
@@ -1,4 +1,4 @@
File "./output/library_attributes_require.v", line 1, characters 0-37:
Warning: Library File TestSuite.library_attributes is deprecated since XX YY.
Warning: Library File TestSuite.deprecated_library is deprecated since XX YY.
This library is useless.
[deprecated-library-file-since-XX-YY,deprecated-since-XX-YY,deprecated-library-file,deprecated,default]
2 changes: 1 addition & 1 deletion test-suite/output/library_attributes_require.v
@@ -1 +1 @@
Require TestSuite.library_attributes.
Require TestSuite.deprecated_library.
6 changes: 3 additions & 3 deletions test-suite/output/library_attributes_require_transitive.out
@@ -1,8 +1,8 @@
File "./output/library_attributes_require_transitive.v", line 5, characters 0-37:
Warning: Library File TestSuite.library_attributes is deprecated since XX YY.
Warning: Library File TestSuite.deprecated_library is deprecated since XX YY.
This library is useless.
[deprecated-library-file-since-XX-YY,deprecated-since-XX-YY,deprecated-library-file,deprecated,default]
File "./output/library_attributes_require_transitive.v", line 11, characters 0-45:
Warning: Library File (transitively required) TestSuite.library_attributes is
File "./output/library_attributes_require_transitive.v", line 11, characters 0-46:
Warning: Library File (transitively required) TestSuite.deprecated_library is
deprecated since XX YY. This library is useless.
[deprecated-transitive-library-file-since-XX-YY,deprecated-since-XX-YY,deprecated-transitive-library-file,deprecated]
6 changes: 3 additions & 3 deletions test-suite/output/library_attributes_require_transitive.v
@@ -1,11 +1,11 @@
(* check that file deprecations are only printed on direct requirement *)
Require TestSuite.library_attributes_require.
Require TestSuite.requires_deprecated_library.
(* but still printed on direct requirement even if the Require doesn't actually
do anything (because file is already loaded) *)
Require TestSuite.library_attributes.
Require TestSuite.deprecated_library.

(* We have the second warning "deprecated-transitive-library-file"
that always triggers (even on transitive requires) *)
Reset Initial.
Set Warnings "deprecated-transitive-library-file".
Require TestSuite.library_attributes_require.
Require TestSuite.requires_deprecated_library.
1 change: 1 addition & 0 deletions test-suite/prerequisite/deprecated_library.v
@@ -0,0 +1 @@
Attributes deprecated(note="This library is useless.", since="XX YY").
1 change: 0 additions & 1 deletion test-suite/prerequisite/library_attributes.v

This file was deleted.

1 change: 0 additions & 1 deletion test-suite/prerequisite/library_attributes_require.v

This file was deleted.

1 change: 1 addition & 0 deletions test-suite/prerequisite/requires_deprecated_library.v
@@ -0,0 +1 @@
Require TestSuite.deprecated_library.

0 comments on commit 1bf8d81

Please sign in to comment.