Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't commit symlinks in the repository (test-suite library_attributes) #18550

Merged
merged 1 commit into from Feb 5, 2024

Conversation

SkySkimmer
Copy link
Contributor

Fix #18548

No idea why that bug happens on coqide-server and not -core or -stdlib but we have historically avoided symlinks in the git repo due to similar issues.

@SkySkimmer SkySkimmer added the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 24, 2024
@SkySkimmer SkySkimmer added this to the 8.19.1 milestone Jan 24, 2024
@SkySkimmer SkySkimmer requested a review from a team as a code owner January 24, 2024 14:48
@coqbot-app coqbot-app bot removed the request: full CI Use this label when you want your next push to trigger a full CI. label Jan 24, 2024
rtetley added a commit to coq-community/vscoq that referenced this pull request Jan 30, 2024
Waiting for coq/coq#18550 to fix issue upstream
@SkySkimmer SkySkimmer added the needs: fixing The proposed code change is broken. label Jan 30, 2024
Fix coq#18548

No idea why that bug happens on coqide-server and not -core or -stdlib
but we have historically avoided symlinks in the git repo due to
similar issues.
@SkySkimmer SkySkimmer removed the needs: fixing The proposed code change is broken. label Jan 30, 2024
@coqbot-app coqbot-app bot added the needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. label Jan 30, 2024
@proux01 proux01 self-assigned this Feb 5, 2024
@proux01 proux01 added kind: infrastructure CI, build tools, development tools. part: test-suite The testing suite. and removed needs: full CI The latest GitLab pipeline that ran was a light CI. Say "@coqbot run full ci" to get a full CI. labels Feb 5, 2024
@proux01
Copy link
Contributor

proux01 commented Feb 5, 2024

@coqbot merge now

@coqbot-app coqbot-app bot merged commit 1bf8d81 into coq:master Feb 5, 2024
5 of 6 checks passed
@coqbot-app coqbot-app bot added this to Request 8.19.1 inclusion in Coq 8.19 Feb 5, 2024
SkySkimmer added a commit that referenced this pull request Feb 5, 2024
@coqbot-app coqbot-app bot moved this from Request 8.19.1 inclusion to Shipped in 8.19.1 in Coq 8.19 Feb 5, 2024
@SkySkimmer SkySkimmer deleted the lib-atts-symlink branch February 5, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: infrastructure CI, build tools, development tools. part: test-suite The testing suite.
Projects
Coq 8.19
Shipped in 8.19.1
Development

Successfully merging this pull request may close these issues.

coqide-server build error on Windows
2 participants