Skip to content

Commit

Permalink
MacOS X install: accepting both dylib and so extensions for gtk immod…
Browse files Browse the repository at this point in the history
…ules.

This was changed from so to dylib in dd7c679, but it seems to
depend on versions of gtk. Accepting both seems ok, assuming that at
least one will work.

(cherry picked from commit 7020c7c)
  • Loading branch information
herbelin authored and gares committed Nov 26, 2020
1 parent 05b3d99 commit b44de3c
Show file tree
Hide file tree
Showing 2 changed files with 18 additions and 17 deletions.
7 changes: 4 additions & 3 deletions Makefile.ide
Original file line number Diff line number Diff line change
Expand Up @@ -262,7 +262,7 @@ $(COQIDEAPP)/Contents/Resources/loaders: $(COQIDEAPP)/Contents

$(COQIDEAPP)/Contents/Resources/immodules: $(COQIDEAPP)/Contents
$(MKDIR) $@
$(INSTALLLIB) "$(GTKLIBS)/gtk-3.0/3.0.0/immodules/"*.dylib $@
$(INSTALLLIB) "$(GTKLIBS)/gtk-3.0/3.0.0/immodules/"*.dylib $@ || $(INSTALLLIB) "$(GTKLIBS)/gtk-3.0/3.0.0/immodules/"*.so $@


$(COQIDEAPP)/Contents/Resources/etc: $(COQIDEAPP)/Contents/Resources/lib
Expand All @@ -271,8 +271,9 @@ $(COQIDEAPP)/Contents/Resources/etc: $(COQIDEAPP)/Contents/Resources/lib
{ "$(PIXBUFBIN)/gdk-pixbuf-query-loaders" $@/../loaders/*.so |\
sed -e "s!/.*\(/loaders/.*.so\)!@executable_path/../Resources/\1!"; } \
> $@/gtk-3.0/gdk-pixbuf.loaders
{ "$(GTKBIN)/gtk-query-immodules-3.0" $@/../immodules/*.dylib |\
{ "$(GTKBIN)/gtk-query-immodules-3.0" $@/../immodules/*.{dylib,so} |\
sed -e "s!/.*\(/immodules/.*.dylib\)!@executable_path/../Resources/\1!" |\
sed -e "s!/.*\(/immodules/.*.so\)!@executable_path/../Resources/\1!" |\
sed -e "s!/.*\(/share/locale\)!@executable_path/../Resources/\1!"; } \
> $@/gtk-3.0/gtk-immodules.loaders
$(MKDIR) $@/pango
Expand All @@ -281,7 +282,7 @@ $(COQIDEAPP)/Contents/Resources/etc: $(COQIDEAPP)/Contents/Resources/lib
$(COQIDEAPP)/Contents/Resources/lib: $(COQIDEAPP)/Contents/Resources/immodules $(COQIDEAPP)/Contents/Resources/loaders $(COQIDEAPP)/Contents $(COQIDEINAPP)
$(MKDIR) $@
macpack -d ../Resources/lib $(COQIDEINAPP)
for i in $@/../loaders/*.so $@/../immodules/*.dylib; \
for i in $@/../loaders/*.so $@/../immodules/*.{dylib,so}; \
do \
macpack -d ../lib $$i; \
done
Expand Down
28 changes: 14 additions & 14 deletions azure-pipelines.yml
Original file line number Diff line number Diff line change
Expand Up @@ -100,17 +100,17 @@ jobs:
make install
displayName: 'Install Coq'
# - script: |
# set -e
# eval $(opam env)
# export PKG_CONFIG_PATH=/usr/local/opt/libffi/lib/pkgconfig
# ./dev/build/osx/make-macos-dmg.sh
# mv _build/*.dmg "$(Build.ArtifactStagingDirectory)/"
# displayName: 'Create the dmg bundle'
# env:
# OUTDIR: '$(Build.BinariesDirectory)'

# - task: PublishBuildArtifacts@1
# inputs:
# pathtoPublish: '$(Build.ArtifactStagingDirectory)'
# artifactName: coq-macOS-installer
- script: |
set -e
eval $(opam env)
export PKG_CONFIG_PATH=/usr/local/opt/libffi/lib/pkgconfig
./dev/build/osx/make-macos-dmg.sh
mv _build/*.dmg "$(Build.ArtifactStagingDirectory)/"
displayName: 'Create the dmg bundle'
env:
OUTDIR: '$(Build.BinariesDirectory)'
- task: PublishBuildArtifacts@1
inputs:
pathtoPublish: '$(Build.ArtifactStagingDirectory)'
artifactName: coq-macOS-installer

0 comments on commit b44de3c

Please sign in to comment.