-
Notifications
You must be signed in to change notification settings - Fork 641
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lia performance regression #11242
Labels
kind: performance
Improvements to performance and efficiency.
Milestone
Comments
I have no clue :( |
fajb
added a commit
to fajb/coq
that referenced
this issue
Dec 6, 2019
- PR coq#9725 fixes completness bugs introduces some inefficiency. The current PR intends to fix the inefficiency while retaining completness. The fix removes a pre-processing step and instead relies on a more elaborate proof format introducing positivity constraints on the fly. fixes coq#11063, fixes coq#11242 - Better interval analysis for product of variables. (fixes coq#11191 , first case) - Generation of positivity constrains for Z.pow (fixes coq#11191 , second case) - More aggressive pruning of (useless) hypotheses
Seems like it could be related to #11063. |
fajb
added a commit
to fajb/coq
that referenced
this issue
Dec 9, 2019
PR coq#9725 fixes completness bugs introduces some inefficiency. The current PR intends to fix the inefficiency while retaining completness. The fix removes a pre-processing step and instead relies on a more elaborate proof format introducing positivity constraints on the fly. Solve bootstrapping issues: RMicromega <-> Rbase <-> lia. Fixes coq#11063 and fixes coq#11242
fajb
added a commit
to fajb/coq
that referenced
this issue
Dec 12, 2019
PR coq#9725 fixes completness bugs introduces some inefficiency. The current PR intends to fix the inefficiency while retaining completness. The fix removes a pre-processing step and instead relies on a more elaborate proof format introducing positivity constraints on the fly. Solve bootstrapping issues: RMicromega <-> Rbase <-> lia. Fixes coq#11063 and fixes coq#11242 and fixes coq#11270
fajb
added a commit
to fajb/coq
that referenced
this issue
Dec 12, 2019
PR coq#9725 fixes completness bugs introduces some inefficiency. The current PR intends to fix the inefficiency while retaining completness. The fix removes a pre-processing step and instead relies on a more elaborate proof format introducing positivity constraints on the fly. Solve bootstrapping issues: RMicromega <-> Rbase <-> lia. Fixes coq#11063 and fixes coq#11242 and fixes coq#11270
ejgallego
pushed a commit
to fajb/coq
that referenced
this issue
Dec 13, 2019
PR coq#9725 fixes completness bugs introduces some inefficiency. The current PR intends to fix the inefficiency while retaining completness. The fix removes a pre-processing step and instead relies on a more elaborate proof format introducing positivity constraints on the fly. Solve bootstrapping issues: RMicromega <-> Rbase <-> lia. Fixes coq#11063 and fixes coq#11242 and fixes coq#11270
ejgallego
pushed a commit
to fajb/coq
that referenced
this issue
Dec 14, 2019
PR coq#9725 fixes completness bugs introduces some inefficiency. The current PR intends to fix the inefficiency while retaining completness. The fix removes a pre-processing step and instead relies on a more elaborate proof format introducing positivity constraints on the fly. Solve bootstrapping issues: RMicromega <-> Rbase <-> lia. Fixes coq#11063 and fixes coq#11242 and fixes coq#11270
ejgallego
pushed a commit
to ejgallego/coq
that referenced
this issue
Dec 14, 2019
PR coq#9725 fixes completness bugs introduces some inefficiency. The current PR intends to fix the inefficiency while retaining completness. The fix removes a pre-processing step and instead relies on a more elaborate proof format introducing positivity constraints on the fly. Solve bootstrapping issues: RMicromega <-> Rbase <-> lia. Fixes coq#11063 and fixes coq#11242 and fixes coq#11270
fajb
added a commit
to fajb/coq
that referenced
this issue
Dec 16, 2019
PR coq#9725 fixes completness bugs introduces some inefficiency. The current PR intends to fix the inefficiency while retaining completness. The fix removes a pre-processing step and instead relies on a more elaborate proof format introducing positivity constraints on the fly. Solve bootstrapping issues: RMicromega <-> Rbase <-> lia. Fixes coq#11063 and fixes coq#11242 and fixes coq#11270
ppedrot
pushed a commit
to ppedrot/coq
that referenced
this issue
Dec 18, 2019
PR coq#9725 fixes completness bugs introduces some inefficiency. The current PR intends to fix the inefficiency while retaining completness. The fix removes a pre-processing step and instead relies on a more elaborate proof format introducing positivity constraints on the fly. Solve bootstrapping issues: RMicromega <-> Rbase <-> lia. Fixes coq#11063 and fixes coq#11242 and fixes coq#11270 (cherry picked from commit 7d961a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Consider this lia goal:
It used to have (close to) good performance in 8.9.0, but times out on Coq master:
Coq 8.9.0:
lia
takes 20.55 secs,Qed
takes 43.705 secsCoq master of Nov 4:
For all tests, I first deleted
.lia.cache
and then rancoqc
on the above file from the command line.I'd be curious to know what caused this, but before I delve into a git bisect, maybe @fajb would have some intuition about what it could be?
The text was updated successfully, but these errors were encountered: