Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Searching for headconcl and headhyp requires manually inserting coercions to Sortclass. #13244

Closed
chdoc opened this issue Oct 22, 2020 · 2 comments · Fixed by #13255
Closed
Labels
kind: regression Problems that were not present in previous versions. part: coercions The coercion mechanism. part: vernac High level command interpretation.
Milestone

Comments

@chdoc
Copy link
Contributor

chdoc commented Oct 22, 2020

Description of the problem

When searching for something like the "contra" lemmas in ssr, a natural search might be headconcl:(~~ _). However, this does not return any results as ~~ _ is always boolean rather than a type, and cannot be the head of a return type. So one has to search for headconcl:(is_true (~~ _)) instead. This is a regression compared to the search function in the ssrsearch module, where the coercion to Prop/Sortclass was inserted automatically

Require Import ssr.ssrbool.
Search headconcl:(~~ _). (* nothing *)
Search headconcl:(is_true (~~ _)). (* contra lemmas *)
Search concl:(~~ _). (* a lot more results *)
Require Import ssrsearch.ssrsearch.
Search (~~ _). (* same contra lemmas as above *)

Coq Version

8.12

@herbelin herbelin added kind: regression Problems that were not present in previous versions. part: coercions The coercion mechanism. part: vernac High level command interpretation. labels Oct 22, 2020
@herbelin
Copy link
Member

Good remark, thanks! Don't know what would be the best. We may seize this limitation to try to type the pattern, so that coercions are inserted anywhere it is needed, and not only at the top.

@herbelin
Copy link
Member

See #13255 for coercion support in Search. Don't hesitate if you have other suggestions.

@coqbot-app coqbot-app bot added this to the 8.13+beta1 milestone Nov 6, 2020
coqbot-app bot added a commit that referenced this issue Nov 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind: regression Problems that were not present in previous versions. part: coercions The coercion mechanism. part: vernac High level command interpretation.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants