assert_succeeds&assert_fails: multisuccess fix
#10966
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JasonGross
added
kind: fix
JasonGross
force-pushed
the
once-assert-succeeds
branch
2 times, most recently
from
0019b07
to
450991a
Compare
SkySkimmer
approved these changes
Oct 28, 2019
|
Will merge tomorrow unless someone complains. |
These tactics now work correctly with multisuccess tactics by wrapping the tactic argument in `once`. Fixes coq#10965
JasonGross
force-pushed
the
once-assert-succeeds
branch
from
53a9487
to
c9adfcd
Compare
|
I've updated this with an even less kludgy way of solving #9114 |
|
bedrock failure looks spurious, see #10992 |
SkySkimmer
added a commit
to SkySkimmer/coq
that referenced
this pull request
Oct 29, 2019
Reviewed-by: SkySkimmer Reviewed-by: Zimmi48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These tactics now work correctly with multisuccess tactics by wrapping
the tactic argument in
once.Kind: bug fix
Fixes / closes #10965
Fixes #9114